fix: trigger ApisixRoute event when service is created #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
==========================================
- Coverage 30.45% 29.99% -0.46%
==========================================
Files 81 81
Lines 9839 9976 +137
==========================================
- Hits 2996 2992 -4
- Misses 6517 6660 +143
+ Partials 326 324 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
pkg/ingress/apisix_route.go
Outdated
| // svc meta key -> ApisixRoute name -> empty | ||
| // map[string]map[string]struct{} | ||
| svcLock sync.RWMutex | ||
| svcMap map[string]map[string]struct{} //*sync.Map |
There was a problem hiding this comment.
we can just use sync.Map ?
There was a problem hiding this comment.
I would like to use more specific types instead of the untyped sync.Map.
test/e2e/suite-ingress/suite-ingress-resource/resourcepushing.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
AlinsRan
reviewed
Jul 20, 2022
test/e2e/suite-ingress/suite-ingress-resource/resourcepushing.go
Outdated
Show resolved
Hide resolved
tao12345666333
approved these changes
Jul 25, 2022
gxthrj
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
Fixes #926