test: keep namespace when test failed in dev mod #1158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
=======================================
Coverage 30.45% 30.45%
=======================================
Files 81 81
Lines 9839 9839
=======================================
Hits 2996 2996
Misses 6517 6517
Partials 326 326 Help us with your feedback. Take ten seconds to tell us how you rate us. |
tao12345666333
requested review from
tao12345666333,
lingsamuel,
tokers and
gxthrj
|
LGTM also cc @AlinsRan |
| @@ -442,6 +442,8 @@ func (s *Scaffold) beforeEach() { | |||
| func (s *Scaffold) afterEach() { | |||
| defer ginkgo.GinkgoRecover() | |||
|
|
|||
| shouldKeepNamespace := false | |||
|
|
|||
| if ginkgo.CurrentSpecReport().Failed() { | |||
There was a problem hiding this comment.
If we keep the namespace, we don't need to dump namespace contents anymore.
There was a problem hiding this comment.
+1.
We can directly check the relevant information
There was a problem hiding this comment.
Is three any situation we still need real-time information from the namespace? Sometimes e2e-test may spend over an hour. Some resources like Event might be deleted.
There was a problem hiding this comment.
We do not currently dump this resource either.
stillfox-lee
force-pushed
the
test/keep-namespace
branch
from
f5a2e57
to
8ce016d
Compare
|
I can help you resolve the conflicts. Just add one commit to delete the action.yml file |
test/e2e/scaffold/scaffold.go
Outdated
| shouldDeleteNamespace := true | ||
| if ginkgo.CurrentSpecReport().Failed() && os.Getenv("E2E_ENV") == "dev" { | ||
| // Keep namespace if test failed in dev mode | ||
| shouldDeleteNamespace = false |
There was a problem hiding this comment.
We are not going to remove the dump feature cuz we need it to debug CI failures.
I mean, if the environment is dev, we can skip dump. When we are in CI environment, we still need dump.
There was a problem hiding this comment.
Sure, my bad. Of course we need dump namespace info in CI. Thanks for your review!
Indeed. I can try to implement it in a simpler way. Thanks for your suggestion. |
|
Thanks |
Type of change:
Related issue
Add environment variable
E2E_ENVto indicate e2e-test environment. If test case failed andE2E_ENV=dev, related resources will not be deleted.What this PR does / why we need it:
Pre-submission checklist: