Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark v2beta3 deprecated #1198

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

tao12345666333
Copy link
Member

xref: #1194

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@AlinsRan
Copy link
Contributor

https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/suite-plugins/suite-plugins-other/plugin_config.go#L538
Need to replace with NewDefaultV2beta3Scaffold

…affold

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1198 (7c3d923) into master (1765ec9) will decrease coverage by 0.48%.
The diff coverage is 1.16%.

❗ Current head 7c3d923 differs from pull request most recent head 7444d05. Consider uploading reports for the commit 7444d05 to get more accurate results

@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
- Coverage   30.45%   29.96%   -0.49%     
==========================================
  Files          81       81              
  Lines        9839    10029     +190     
==========================================
+ Hits         2996     3005       +9     
- Misses       6517     6697     +180     
- Partials      326      327       +1     
Impacted Files Coverage Δ
pkg/config/config.go 65.34% <ø> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/endpointslice.go 0.00% <0.00%> (ø)
pkg/ingress/utils/manifest.go 45.62% <0.00%> (ø)
pkg/ingress/utils/string.go 0.00% <0.00%> (ø)
cmd/ingress/ingress.go 79.04% <100.00%> (+0.20%) ⬆️
pkg/kube/translation/apisix_route.go 20.60% <100.00%> (ø)
pkg/kube/translation/translator.go 40.47% <100.00%> (+6.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tao12345666333 tao12345666333 merged commit cccad72 into apache:master Jul 29, 2022
@tao12345666333 tao12345666333 deleted the v2beta3-deprecated branch July 29, 2022 11:18
@tao12345666333 tao12345666333 mentioned this pull request Jul 29, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants