Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add log rotate #1200

Merged
merged 8 commits into from
Aug 11, 2022
Merged

feat: add log rotate #1200

merged 8 commits into from
Aug 11, 2022

Conversation

xiangtianyu
Copy link
Contributor

@xiangtianyu xiangtianyu commented Jul 29, 2022 •
edited by lingsamuel

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

add log rotate support
fixes #950

@tao12345666333
Copy link
Member

sorry for delay, thanks for your contribution!

@tao12345666333 tao12345666333 added enhancement New feature or request area/controller labels Aug 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022 •
edited

Codecov Report

Merging #1200 (17f6b1a) into master (537501c) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
+ Coverage   42.64%   42.78%   +0.13%     
==========================================
  Files          73       73              
  Lines        6462     6477      +15     
==========================================
+ Hits         2756     2771      +15     
  Misses       3409     3409              
  Partials      297      297
Impacted Files Coverage Δ
cmd/ingress/ingress.go 80.70% <100.00%> (+2.06%) ⬆️
pkg/config/config.go 66.34% <100.00%> (+1.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lingsamuel
lingsamuel approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@lingsamuel lingsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tao12345666333
tao12345666333 reviewed Aug 10, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
tao12345666333
tao12345666333 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 changed the title add log rotate feat: add log rotate Aug 11, 2022
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Aug 11, 2022
@tao12345666333 tao12345666333 merged commit fcfa188 into apache:master Aug 11, 2022
@tao12345666333 tao12345666333 mentioned this pull request Aug 11, 2022
Closed
@xiangtianyu xiangtianyu deleted the feature/log_rotate branch August 11, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

@AlinsRan AlinsRan AlinsRan approved these changes

@tokers tokers Awaiting requested review from tokers

Assignees
No one assigned
Labels
area/controller enhancement New feature or request
Projects
Apache APISIX Ingress controller
Status: Done
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

feat request: rotate log
5 participants
@xiangtianyu @tao12345666333 @codecov-commenter @lingsamuel @AlinsRan