Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Refactor the README #1215

Merged
merged 4 commits into from
Aug 4, 2022
Merged

doc: Refactor the README #1215

merged 4 commits into from
Aug 4, 2022

Conversation

nfrankel
Copy link
Contributor

@nfrankel nfrankel commented Aug 4, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation

What this PR does / why we need it:

  • Reorder sections
  • Merge sections
  • Remove license section as GitHub makes it prominently clear

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@nfrankel
Refactor the README
5e58f66 
  Reorder sections
  Merge sections
  Remove license section as GitHub makes it prominently clear
@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label Aug 4, 2022
tao12345666333
tao12345666333 reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
nfrankel and others added 2 commits August 4, 2022 06:43
@nfrankel @tao12345666333
Accept review change
9065fae 
Co-authored-by: Jintao Zhang <tao12345666333@163.com>
@tao12345666333
merge
11a6a81 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
tao12345666333 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Aug 4, 2022
@gxthrj gxthrj merged commit 92c1adb into apache:master Aug 4, 2022
AlinsRan pushed a commit to AlinsRan/apisix-ingress-controller that referenced this pull request Aug 11, 2022
@nfrankel @AlinsRan
doc: Refactor the README (apache#1215)
e1d9b59
AlinsRan pushed a commit to AlinsRan/apisix-ingress-controller that referenced this pull request Aug 11, 2022
@nfrankel @AlinsRan
doc: Refactor the README (apache#1215)
40a7db0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@gxthrj gxthrj gxthrj approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nfrankel @tao12345666333 @gxthrj @lingsamuel