Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log Secret name instead of all data #1216

Merged
merged 4 commits into from
Aug 17, 2022
Merged

fix: log Secret name instead of all data #1216

merged 4 commits into from
Aug 17, 2022

Conversation

zaunist
Copy link
Contributor

@zaunist zaunist commented Aug 4, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

fix #1045

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #1216 (853b227) into master (7115cef) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
+ Coverage   42.64%   42.78%   +0.13%     
==========================================
  Files          73       73              
  Lines        6462     6477      +15     
==========================================
+ Hits         2756     2771      +15     
  Misses       3409     3409              
  Partials      297      297              
Impacted Files Coverage Δ
pkg/config/config.go 66.34% <0.00%> (+1.34%) ⬆️
cmd/ingress/ingress.go 80.70% <0.00%> (+2.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333
Copy link
Member

sorry for delay. please resolve conflicts. thanks!

@zaunist
Copy link
Contributor Author

zaunist commented Aug 15, 2022

@tao12345666333 PTAL, thanks.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Aug 16, 2022
@tao12345666333
Copy link
Member

ping @lingsamuel for review, thanks

@lingsamuel lingsamuel merged commit 2fa8a9c into apache:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log: shouldn't log secret object
5 participants