Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update secret referenced by ingress #1243

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

lingsamuel
Copy link
Member

@lingsamuel lingsamuel commented Aug 12, 2022

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • Bugfix

What this PR does / why we need it:

Fixes #1190

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #1243 (3057c84) into master (4fa3b56) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
- Coverage   40.92%   40.62%   -0.31%     
==========================================
  Files          75       75              
  Lines        6954     7006      +52     
==========================================
  Hits         2846     2846              
- Misses       3795     3847      +52     
  Partials      313      313              
Impacted Files Coverage Δ
pkg/providers/apisix/translation/apisix_ssl.go 0.00% <0.00%> (ø)
pkg/providers/ingress/ingress.go 4.04% <0.00%> (-1.10%) ⬇️
pkg/providers/ingress/provider.go 0.00% <0.00%> (ø)
pkg/providers/ingress/translation/translator.go 0.00% <0.00%> (ø)
pkg/providers/translation/util.go 15.00% <0.00%> (-3.19%) ⬇️
pkg/providers/utils/ingress_status.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Sep 16, 2022
@tao12345666333 tao12345666333 merged commit e51a2c7 into apache:master Sep 21, 2022
@lingsamuel lingsamuel deleted the ingress-update-tls-2 branch September 22, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

help request: ingress TLS certificate update
5 participants