Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: annotations #1245

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Aug 15, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

  • Decouple the transformation of resources and annotations.
  • Improved code scalability.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan marked this pull request as ready for review August 15, 2022 03:55
@codecov-commenter
Copy link

Codecov Report

Merging #1245 (3c197ad) into master (fcfa188) will decrease coverage by 2.85%.
The diff coverage is 36.14%.

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   42.78%   39.92%   -2.86%     
==========================================
  Files          73       75       +2     
  Lines        6477     6961     +484     
==========================================
+ Hits         2771     2779       +8     
- Misses       3409     3883     +474     
- Partials      297      299       +2     
Impacted Files Coverage Δ
...ingress/translation/annotations/plugins/plugins.go 0.00% <0.00%> (ø)
pkg/providers/ingress/translation/translator.go 0.00% <0.00%> (ø)
...ngress/translation/annotations/plugins/redirect.go 12.50% <20.00%> (ø)
...ingress/translation/annotations/plugins/rewrite.go 11.11% <20.00%> (ø)
...rs/ingress/translation/annotations/plugins/csrf.go 16.66% <25.00%> (ø)
...s/translation/annotations/plugins/authorization.go 22.22% <33.33%> (ø)
pkg/providers/ingress/translation/annotations.go 58.82% <72.72%> (ø)
...rs/ingress/translation/annotations/plugins/cors.go 100.00% <100.00%> (ø)
...ss/translation/annotations/plugins/forward_auth.go 100.00% <100.00%> (ø)
...s/translation/annotations/plugins/iprestriction.go 100.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333 tao12345666333 self-assigned this Aug 29, 2022
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Aug 29, 2022
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 0b999ec into apache:master Aug 30, 2022
@AlinsRan AlinsRan deleted the refactor/annotations2 branch September 2, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants