fix: support resolveGranularity of ApisixRoute #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinsRan
changed the title
| return nil | ||
| } | ||
|
|
||
| func (u *upstreamService) Create(ctx context.Context, relation *v1.UpstreamServiceRelation) error { | ||
| // to do: delete one of |
There was a problem hiding this comment.
Delete one of the upstreams. Currently, only service is deleted. There will be some redundant objects, but the results will not be affected.
|
Also, please adjust your parameter order |
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
+ Coverage 39.77% 40.92% +1.15%
==========================================
Files 75 75
Lines 6967 6954 -13
==========================================
+ Hits 2771 2846 +75
+ Misses 3897 3795 -102
- Partials 299 313 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlinsRan
requested review from
tao12345666333
and removed request for
tokers and
lingsamuel
Done. |
|
I want you can add an e2e test case to cover #870, thanks! |
lingsamuel
reviewed
Sep 9, 2022
lingsamuel
reviewed
Sep 9, 2022
| if err != nil { | ||
| if err == apisixcache.ErrNotFound { | ||
| continue | ||
| update := func(upsName string) error { |
There was a problem hiding this comment.
Can it be a function instead of a local variable?
There was a problem hiding this comment.
Yes, but it has many contexts, requires more parameters, and can't be reused. I do not recommend this.
lingsamuel
reviewed
Sep 9, 2022
AlinsRan
requested review from
lingsamuel
and removed request for
tokers and
gxthrj
lingsamuel
approved these changes
Sep 9, 2022
This was referenced Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
ref:
fixes:
resolveGranularityshould be considered in upstream id generation #1157Pre-submission checklist: