Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: object type should be apisix_upstream and endpointslice and apisix_cluster_config #1268

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Aug 24, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan changed the title fix: object type should be ApisixUpstreamEvent fix: object type should be apisix_upstream and endpointslice and apisix_cluster_config Aug 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1268 (cdfe0f1) into master (530ce52) will not change coverage.
The diff coverage is n/a.

❗ Current head cdfe0f1 differs from pull request most recent head 04abf7e. Consider uploading reports for the commit 04abf7e to get more accurate results

@@           Coverage Diff           @@
##           master    #1268   +/-   ##
=======================================
  Coverage   42.72%   42.72%           
=======================================
  Files          73       73           
  Lines        6486     6486           
=======================================
  Hits         2771     2771           
  Misses       3418     3418           
  Partials      297      297           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants