Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config missing default_cluster_name yaml #1277

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

xiangtianyu
Copy link
Contributor

@xiangtianyu xiangtianyu commented Aug 27, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

fix #1264

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #1277 (3ddac76) into master (4eede7e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1277   +/-   ##
=======================================
  Coverage   42.72%   42.72%           
=======================================
  Files          73       73           
  Lines        6486     6486           
=======================================
  Hits         2771     2771           
  Misses       3418     3418           
  Partials      297      297           
Impacted Files Coverage Δ
pkg/config/config.go 66.34% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Aug 29, 2022
pkg/config/config_test.go Outdated Show resolved Hide resolved
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit f1bd4c0 into apache:master Aug 29, 2022
@xiangtianyu xiangtianyu deleted the bugfix branch August 30, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

request help: 默认集群名称始终为default
5 participants