doc: update develop.md #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 61.22% 61.79% +0.56%
==========================================
Files 16 16
Lines 539 547 +8
==========================================
+ Hits 330 338 +8
Misses 185 185
Partials 24 24
Continue to review full report at Codecov.
|
gxthrj
reviewed
Dec 24, 2020
gxthrj
reviewed
Dec 24, 2020
| @@ -89,12 +93,14 @@ spec: | |||
| http: | |||
| paths: | |||
| - backend: | |||
| serviceName: httpserver | |||
| serviceName: httpbin.default.svc.cluster.local | |||
There was a problem hiding this comment.
I found the port of httpbin container is 80, the port should be change to 80 instead of 8080.
Or we do need a service file to describe the port Mapping.
There was a problem hiding this comment.
OK, let me add the service/deployment description in doc.
| @@ -115,7 +121,7 @@ spec: | |||
| http: | |||
| paths: | |||
| - backend: | |||
| serviceName: httpserver | |||
| serviceName: httpbin.default.svc.cluster.local | |||
| servicePort: 8080 | |||
| @@ -165,7 +171,7 @@ kubectl apply -f - <<EOF | |||
| apiVersion: apisix.apache.org/v1 | |||
| kind: ApisixUpstream # apisix upstream | |||
| metadata: | |||
| name: httpserver # default/httpserver | |||
| name: httpbin # default/httpbin | |||
| spec: | |||
| ports: | |||
| - port: 8080 | |||
gxthrj
approved these changes
Dec 24, 2020
|
@membphis Please take a look when you have time. |
moonming
approved these changes
Dec 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #30.