Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support update and delete for HTTPRoute #1315

Merged
merged 5 commits into from
Sep 7, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Sep 2, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #1315 (392d654) into master (866d40f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   39.77%   39.77%           
=======================================
  Files          75       75           
  Lines        6967     6967           
=======================================
  Hits         2771     2771           
  Misses       3897     3897           
  Partials      299      299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333
Copy link
Member

closes #1326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants