Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crd resource status is not updated #1335

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Sep 15, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

ref:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #1335 (0f1e92f) into master (85bcfbc) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1335   +/-   ##
=======================================
  Coverage   40.92%   40.92%           
=======================================
  Files          75       75           
  Lines        6954     6954           
=======================================
  Hits         2846     2846           
  Misses       3795     3795           
  Partials      313      313           
Impacted Files Coverage Δ
pkg/providers/utils/status.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan marked this pull request as ready for review September 15, 2022 05:39
@tao12345666333 tao12345666333 linked an issue Sep 16, 2022 that may be closed by this pull request
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Sep 16, 2022
@tao12345666333 tao12345666333 merged commit 4fa3b56 into apache:master Sep 16, 2022
@tao12345666333
Copy link
Member

We can cherry-pick it to the v1.5 branch

tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Sep 16, 2022
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Member

#1336

tao12345666333 added a commit that referenced this pull request Sep 16, 2022
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

ApisixTls status not updated
4 participants