Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ingress extensions/v1beta1 support tls #1392

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

shareinto
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Resolve #1387

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #1392 (e69dfb2) into master (5f2c398) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
- Coverage   40.47%   40.42%   -0.06%     
==========================================
  Files          78       78              
  Lines        7076     7085       +9     
==========================================
  Hits         2864     2864              
- Misses       3897     3906       +9     
  Partials      315      315              
Impacted Files Coverage Δ
pkg/providers/ingress/translation/translator.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Oct 20, 2022
@tao12345666333 tao12345666333 merged commit dcd57bb into apache:master Oct 23, 2022
shareinto added a commit to shareinto/apisix-ingress-controller that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

bug: ingress extensions/v1beta1 seems like does not support tls
4 participants