docs: update annotations page #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
pottekkat
requested review from
tao12345666333,
bzp2010,
lingsamuel,
soulbird and
tokers
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
|
@tao12345666333 I have moved back the page to under concepts. |
tao12345666333
approved these changes
Oct 24, 2022
juzhiyuan
approved these changes
Oct 24, 2022
|
@tao12345666333 Now that I think about it, one of the reasons I thought moving the annotations page to a separate root-level page was discoverability for the user. An APISIX Ingress user might want to look up the annotations available and it might not be intuitive to check under the concepts section. |
shareinto
pushed a commit
to shareinto/apisix-ingress-controller
that referenced
this pull request
Oct 27, 2022
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Navendu Pottekkat navendu@apache.org
Updates "Annotations" page.
Moves the page out of the "Concepts" section as a separate reference guide.