Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update "FAQ" page #1437

Merged
merged 3 commits into from
Nov 11, 2022
Merged

docs: update "FAQ" page #1437

merged 3 commits into from
Nov 11, 2022

Conversation

pottekkat
Copy link
Contributor

Signed-off-by: Navendu Pottekkat navendu@apache.org

Updated the FAQ page docs.

Signed-off-by: Navendu Pottekkat <navendu@apache.org>
@pottekkat
Copy link
Contributor Author

pottekkat commented Nov 4, 2022

Trailing punctuation of ? should be allowed in headings as FAQ pages will have them.

Edit: By default ? should be ignored. Might be a bug on the markdownlint-cli.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix lint error. thanks

@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label Nov 9, 2022
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
@pottekkat
Copy link
Contributor Author

@tao12345666333 So I updated the version of the markdownlint tool. That seems to fix the issue.

Signed-off-by: Navendu Pottekkat <navendu@apache.org>
@tao12345666333 tao12345666333 merged commit e18f157 into apache:master Nov 11, 2022
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Nov 11, 2022
@pottekkat pottekkat deleted the docs/FAQ/1 branch November 11, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants