chore: gateway-api v0.5.1 #1445
Conversation
Makefile
Outdated
|
|
||
| ### uninstall-gateway-api: Uninstall Gateway API CRDs from the K8s cluster. | ||
| .PHONY: uninstall-gateway-api | ||
| uninstall-gateway-api: go-mod-download-gateway-api |
There was a problem hiding this comment.
why we need go-mod-download-gateway-api?
There was a problem hiding this comment.
but its uninstall-gateway-api
There was a problem hiding this comment.
Isn't it weird that I'm being asked to update it first when I want to delete it?
There was a problem hiding this comment.
This package does not exist when uninstalling is mainly avoided.
There was a problem hiding this comment.
This is obviously not necessary.
I can get the name of the CRD in the following two ways
kubectl api-resources --api-group=gateway.networking.k8s.io -o name
or
kubectl get crds | awk '/gateway.networking.k8s.io/ {print $1}'
Then I can get the output:
gatewayclasses.gateway.networking.k8s.io
httproutes.gateway.networking.k8s.io
referencepolicies.gateway.networking.k8s.io
tcproutes.gateway.networking.k8s.io
tlsroutes.gateway.networking.k8s.io
udproutes.gateway.networking.k8s.io
Just need a for loop, you can delete these CRD resources directly.
This does not require any dependencies, even an offline environment.
There was a problem hiding this comment.
This is not very convenient. There is also a gateway-api webhook.
Makefile
Outdated
|
|
||
| GATEWAY_API_PACKAGE ?= sigs.k8s.io/gateway-api | ||
| GATEWAY_API_VERSION ?= v0.5.1 | ||
| GATEWAY_API_CRDS_LOCAL_PATH = $(shell go env GOPATH)/pkg/mod/$(GATEWAY_API_PACKAGE)@$(GATEWAY_API_VERSION)/config/crd |
There was a problem hiding this comment.
If we already keep a copy of this CRD configuration in the our repo, why not just use this copy to install?
There was a problem hiding this comment.
Dependent updates are convenient. The CRDs in the repo as an example, and maybe we can delete it?
There was a problem hiding this comment.
I think we should keep that copy for anyone to use offline
Codecov Report
@@ Coverage Diff @@
## master #1445 +/- ##
==========================================
+ Coverage 41.25% 41.35% +0.10%
==========================================
Files 82 82
Lines 7279 7261 -18
==========================================
Hits 3003 3003
+ Misses 3929 3911 -18
Partials 347 347
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlinsRan
force-pushed
the
chore/gateway
branch
from
c459e74
to
664b161
Compare
|
|
||
| ### install: Install Gateway API into the K8s cluster from go mod. | ||
| .PHONY: install-gateway-api | ||
| install-gateway-api: go-mod-download-gateway-api |
There was a problem hiding this comment.
I don't think it's necessary since we have a local copy.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: