Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify Dockerfile go version from 1.18 to 1.19 ,consist with go mod #1446

Merged
merged 1 commit into from
Nov 10, 2022
Merged

modify Dockerfile go version from 1.18 to 1.19 ,consist with go mod #1446

merged 1 commit into from
Nov 10, 2022

Conversation

StevenBrown008
Copy link
Contributor

@StevenBrown008 StevenBrown008 commented Nov 9, 2022 •
edited

Type of change:

  • Bugfix

What this PR does / why we need it:

modify Dockerfile go version from 1.18 to 1.19 , consist with go mod.
relate to #1290 #1357

Pre-submission checklist:

  • solve image package base go version (1.18) not consist with code develop go version (1.19)

@StevenBrown008
Copy link
Contributor Author

@tao12345666333 @tokers @lingsamuel please cc

@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Nov 9, 2022
@lingsamuel lingsamuel merged commit febeab4 into apache:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

@AlinsRan AlinsRan Awaiting requested review from AlinsRan

Assignees
No one assigned
Labels
CI
Projects
Apache APISIX Ingress controller
Status: Done
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StevenBrown008 @tao12345666333 @lingsamuel