Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support apisix v3 admin api #1449

Merged
merged 15 commits into from
Nov 19, 2022
Merged

Conversation

lingsamuel
Copy link
Member

@lingsamuel lingsamuel commented Nov 11, 2022

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • New feature provided

What this PR does / why we need it:

Add flag apisix-admin-api-version to support APISIX 3.0 admin API.
This PR make APISIX v3 as default version of e2e tests. Also add a cronjob everyday for v2 e2e tests.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel lingsamuel changed the title feat: support apisix v3 admin api [DRAFT] feat: support apisix v3 admin api Nov 11, 2022
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #1449 (9c14a6d) into master (febeab4) will decrease coverage by 0.01%.
The diff coverage is 47.95%.

@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   41.30%   41.28%   -0.02%     
==========================================
  Files          82       82              
  Lines        7271     7300      +29     
==========================================
+ Hits         3003     3014      +11     
- Misses       3921     3934      +13     
- Partials      347      352       +5     
Impacted Files Coverage Δ
pkg/api/validation/utils.go 32.43% <0.00%> (ø)
pkg/apisix/plugin_metadata.go 4.39% <0.00%> (ø)
pkg/apisix/resource.go 56.79% <ø> (ø)
pkg/config/config.go 64.13% <ø> (ø)
pkg/apisix/cluster.go 36.39% <35.00%> (-1.66%) ⬇️
pkg/apisix/consumer.go 36.30% <50.00%> (ø)
pkg/apisix/global_rule.go 36.05% <50.00%> (ø)
pkg/apisix/pluginconfig.go 36.91% <50.00%> (ø)
pkg/apisix/route.go 38.51% <50.00%> (ø)
pkg/apisix/stream_route.go 36.42% <50.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lingsamuel lingsamuel changed the title [DRAFT] feat: support apisix v3 admin api feat: support apisix v3 admin api Nov 14, 2022
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Nov 14, 2022
@AlinsRan

This comment was marked as resolved.

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel lingsamuel added the area/test/apiv2 Trigger for APISIX admin API v2 e2e. label Nov 14, 2022
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel lingsamuel added area/test/apiv2 Trigger for APISIX admin API v2 e2e. and removed area/test/apiv2 Trigger for APISIX admin API v2 e2e. labels Nov 14, 2022
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333 tao12345666333 merged commit be7edf6 into apache:master Nov 19, 2022
@tao12345666333 tao12345666333 linked an issue Nov 25, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test/apiv2 Trigger for APISIX admin API v2 e2e.
Projects
Development

Successfully merging this pull request may close these issues.

feat: Compatible with APISIX v3
4 participants