Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace io/ioutil package #1485

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

ronething
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

As of Go 1.16, io/ioutil package is deprecated, and the same functionality is now provided by package io or package os, so we maybe can replace io/ioutil package.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #1485 (39ba77a) into master (ed92690) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1485   +/-   ##
=======================================
  Coverage   41.26%   41.26%           
=======================================
  Files          83       83           
  Lines        7365     7365           
=======================================
  Hits         3039     3039           
  Misses       3972     3972           
  Partials      354      354           
Impacted Files Coverage Δ
pkg/apisix/cluster.go 36.12% <100.00%> (ø)
pkg/config/config.go 64.13% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ronething
Copy link
Contributor Author

@tao12345666333 hi, can you please take a look, thx.

@tao12345666333 tao12345666333 merged commit 1097792 into apache:master Dec 5, 2022
@tao12345666333
Copy link
Member

Thanks!

@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Dec 5, 2022
@ronething ronething deleted the chore/no_ioutil branch December 5, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants