e2e: support docker hub as registry #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
+ Coverage 41.26% 41.38% +0.12%
==========================================
Files 83 84 +1
Lines 7365 7382 +17
==========================================
+ Hits 3039 3055 +16
- Misses 3972 3974 +2
+ Partials 354 353 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlinsRan
changed the title
| @@ -72,7 +72,7 @@ spec: | |||
| tcpSocket: | |||
| port: 9080 | |||
| timeoutSeconds: 2 | |||
| image: "localhost:5000/apache/apisix:dev" | |||
| image: "localhost:5000/apisix:dev" | |||
There was a problem hiding this comment.
We could also add a global variable that stores the $REGISTRY used instead of hardcoding it here.
There was a problem hiding this comment.
Relevant processing logic already exists.
https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/scaffold/scaffold.go#L588
lingsamuel
approved these changes
Dec 8, 2022
tao12345666333
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
The free docker hub account does not support multi-level paths. such as api
docker.io/xxx/xxx/xxx.The
${REGISTRY}/apache/apisix:devunable to push to personal docker hub.Pre-submission checklist: