Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unified factory and informer #1530

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Dec 16, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

fix:

With the increase of functional requirements, the interdependence between resources is inevitable. We should unify the informer structure to avoid errors caused by resources not being ready.

image

image

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #1530 (8698487) into master (d22a6fc) will increase coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1530      +/-   ##
==========================================
+ Coverage   41.22%   41.41%   +0.18%     
==========================================
  Files          85       85              
  Lines        7440     7406      -34     
==========================================
  Hits         3067     3067              
+ Misses       4020     3986      -34     
  Partials      353      353              
Impacted Files Coverage Δ
pkg/providers/ingress/ingress.go 4.09% <0.00%> (+0.10%) ⬆️
pkg/providers/ingress/provider.go 0.00% <0.00%> (ø)
pkg/providers/k8s/pod/provider.go 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan marked this pull request as ready for review December 16, 2022 06:00
Co-authored-by: Jintao Zhang <tao12345666333@163.com>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333
Copy link
Member

I communicated offline with @AlinsRan who has been testing this PR for a long time.

So I think it's safe to merge it now

@tao12345666333
Copy link
Member

I think we should add some performance testing, and get related metrics and reports.

@tao12345666333 tao12345666333 merged commit 4208ca7 into apache:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants