Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix sync delete svc error #1576

Merged
merged 6 commits into from
Feb 10, 2023
Merged

fix: fix sync delete svc error #1576

merged 6 commits into from
Feb 10, 2023

Conversation

Fabriceli
Copy link
Contributor

@Fabriceli Fabriceli commented Jan 2, 2023 •
edited
Loading

Type of change:

  • Bugfix

What this PR does / why we need it:

#1528

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Fabriceli Fabriceli changed the title fix: fix sync delete svc error #1528 fix: fix sync delete svc error Jan 2, 2023
@Fabriceli
Copy link
Contributor Author

@tao12345666333 please take a look at this PR, thanks

@tao12345666333
Copy link
Member

thanks

tao12345666333
tao12345666333 reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add e2e test cases to cover this

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023 •
edited
Loading

Codecov Report

Merging #1576 (03c8130) into master (486b46a) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
- Coverage   41.44%   41.36%   -0.08%     
==========================================
  Files          87       87              
  Lines        7420     7434      +14     
==========================================
  Hits         3075     3075              
- Misses       3990     4004      +14     
  Partials      355      355
Impacted Files Coverage Δ
pkg/providers/ingress/ingress.go 4.05% <0.00%> (-0.04%) ⬇️
pkg/providers/ingress/translation/translator.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Fabriceli
Copy link
Contributor Author

Please add e2e test cases to cover this

how can i run this e2e test in local? cc @tao12345666333

@tao12345666333
Copy link
Member

Please check Makefile

@Fabriceli
Copy link
Contributor Author

Please check Makefile

done, added e2e test

@Fabriceli
Copy link
Contributor Author

Could you give some hint about this error:

The push refers to repository [localhost:5000/apisix]
Get "http://localhost:5000/v2/": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
make: *** [push-images] Error 1

Run this command make e2e-test-local in local terminal, cc @tao12345666333

@Fabriceli
Copy link
Contributor Author

@tao12345666333 please take a look at this PR, i had fixed the e2e test error, thanks

@tao12345666333 tao12345666333 added bug Something isn't working area/controller labels Jan 6, 2023
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Jan 6, 2023
@tao12345666333 tao12345666333 linked an issue Jan 6, 2023 that may be closed by this pull request
bug: When deleting ingress, because the service or endpoints do not exist to failed. #1528
Closed
@Fabriceli
Copy link
Contributor Author

@AlinsRan please take a look at this PR, thanks

@Fabriceli
Copy link
Contributor Author

@tao12345666333 @AlinsRan please take a look at this PR, thanks

@tao12345666333
Copy link
Member

Sorry for delay, let me take a look.

@Fabriceli
Copy link
Contributor Author

Sorry for delay, let me take a look.

@tao12345666333 please take a look at this PR, thanks

@tao12345666333 tao12345666333 merged commit a0a50fe into apache:master Feb 10, 2023
lingsamuel pushed a commit to lingsamuel/apisix-ingress-controller that referenced this pull request Mar 31, 2023
@Fabriceli @lingsamuel
fix: Ingress delete events can be handler after svc be deleted (apach…
7d3c5b9 
…e#1576)

Co-authored-by: Fabriceli <li842162578@gmail.com>
@lingsamuel lingsamuel mentioned this pull request Mar 31, 2023
Merged
1 task
lingsamuel added a commit that referenced this pull request Mar 31, 2023
@lingsamuel @Fabriceli
fix: Ingress delete events can be handler after svc be deleted (#1576) (
b570843 
#1755)

Co-authored-by: fabriceli <yihao.li.cn@hotmail.com>
Co-authored-by: Fabriceli <li842162578@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@AlinsRan AlinsRan AlinsRan approved these changes

Assignees
No one assigned
Labels
area/controller bug Something isn't working process/cherry-pick
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

bug: When deleting ingress, because the service or endpoints do not exist to failed.
4 participants
@Fabriceli @tao12345666333 @codecov-commenter @AlinsRan