Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update the-hard-way.md #1581

Merged
merged 1 commit into from
Jan 3, 2023
Merged

docs: Update the-hard-way.md #1581

merged 1 commit into from
Jan 3, 2023

Conversation

JichinX
Copy link
Contributor

@JichinX JichinX commented Jan 3, 2023

fix a docs error where create configmap before create apisix deployment.

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@JichinX
Update the-hard-way.md
5847c44 
fix a docs error where create caonfigmap before create apisix deployment.
@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label Jan 3, 2023
tao12345666333
tao12345666333 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! thanks

@tao12345666333 tao12345666333 changed the title Update the-hard-way.md docs: Update the-hard-way.md Jan 3, 2023
@pottekkat pottekkat merged commit 66d9434 into apache:v1.6.0 Jan 3, 2023
tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Jan 4, 2023
@JichinX @tao12345666333
docs: Update the-hard-way.md (apache#1581)
5134938
@tao12345666333 tao12345666333 mentioned this pull request Jan 4, 2023
Merged
8 tasks
pottekkat pushed a commit that referenced this pull request Jan 4, 2023
@tao12345666333 @JichinX
docs: Update the-hard-way.md (#1581) (#1584)
78272a5 
Co-authored-by: JiChang Xu <xujichang@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@pottekkat pottekkat pottekkat approved these changes

@lingsamuel lingsamuel Awaiting requested review from lingsamuel

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JichinX @tao12345666333 @pottekkat