-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ApisixGlobalRule support global rules #1586
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
- Coverage 41.44% 41.18% -0.26%
==========================================
Files 87 88 +1
Lines 7420 7485 +65
==========================================
+ Hits 3075 3083 +8
- Misses 3990 4043 +53
- Partials 355 359 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code overall LGTM
one question, how to deal with conflicts between ApisixGlobalRule and ApisixClusterConfig?
There are two conflicts:
For 1, ApisixGlobalRule is a namespace-level resource that constructs objects based on namespace-name, and there is no identical name. For 2, use plugins in different global-rules objects, APISIX does not restrict this. (Of course, we need to point it out in the documentation, or recommend users to use ApisixGlobalRule) |
Type of change:
What this PR does / why we need it:
Close: #1104
Pre-submission checklist: