ci: add yamllint rules #1666
ci: add yamllint rules #1666
Conversation
|
@tao12345666333 PTAL, thanks! |
.yamllint.yml
Outdated
| empty-values: disable | ||
| float-values: disable | ||
| hyphens: enable | ||
| indentation: disable # default: enable |
There was a problem hiding this comment.
@tao12345666333 When i enable empty-values or indentation options, i find some error in CI action as shown below, then i use https://www.json2yaml.com/convert-yaml-to-json tool to check yaml file it seems valid, so maybe we can disabled it?
There was a problem hiding this comment.
@sakulali we should enable these options and fix the format of YAML. Thanks
There was a problem hiding this comment.
@sakulali we should enable these options and fix the format of YAML. Thanks
@tao12345666333 , Sorry for delay, when i use https://github.com/google/yamlfmt to fix the format of YAML, there are too much differences vs original files, too much change maybe not good?
There was a problem hiding this comment.
don't worry. It doesn't have any real impact on users.
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
==========================================
+ Coverage 41.02% 41.42% +0.40%
==========================================
Files 88 88
Lines 7564 7642 +78
==========================================
+ Hits 3103 3166 +63
- Misses 4101 4112 +11
- Partials 360 364 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@lingsamuel, @AlinsRan, would you do me a favor to review this pr, thanks! |
Type of change:
fix: #1062
Add
yamllintrules checksamples/deploy/directoryWhat this PR does / why we need it:
Pre-submission checklist: