Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add regression testing with apisix:dev #1721

Merged
merged 18 commits into from
Apr 23, 2023
Merged

Conversation

ps-19
Copy link
Contributor

@ps-19 ps-19 commented Mar 10, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

The PR tries to add regression testing with apisix:dev . It tries to resolve issue#1075 (#1075). Previously, apisix:dev was used for e2e testing by default, but this affected the development experience and sometimes resulted in false negatives where e2e tests failed due to changes in APISIX. By adding a scheduled job to use apisix:dev image for regression testing, your PR aims to address these concerns and improve the testing process.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #1721 (c4eed67) into master (98ff8e5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head c4eed67 differs from pull request most recent head bb6cf30. Consider uploading reports for the commit bb6cf30 to get more accurate results

@@            Coverage Diff             @@
##           master    #1721      +/-   ##
==========================================
- Coverage   39.30%   39.29%   -0.01%     
==========================================
  Files          91       91              
  Lines        8073     8075       +2     
==========================================
  Hits         3173     3173              
- Misses       4494     4495       +1     
- Partials      406      407       +1     
Impacted Files Coverage Δ
...kg/providers/apisix/translation/apisix_consumer.go 65.21% <0.00%> (-1.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Makefile Outdated Show resolved Hide resolved
.github/workflows/e2e-test-ci-v2-cron-dev.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-test-ci-v2-cron-dev.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-test-ci-v2-cron-dev.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-test-ci-v2-cron-dev.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-test-ci-v2-cron-dev.yml Outdated Show resolved Hide resolved
@ps-19
Copy link
Contributor Author

ps-19 commented Mar 10, 2023

I made some changes and added comment for clarification. Kindly have a look.

@ps-19 ps-19 changed the title Issue #1075 CI: add regression testing with apisix:dev Mar 29, 2023
Makefile Outdated Show resolved Hide resolved
@ps-19 ps-19 requested a review from AlinsRan April 3, 2023 08:00
Makefile Outdated Show resolved Hide resolved
@lingsamuel
Copy link
Member

Please sync changes from e2e-test-ci.yml, there are some necessary stability fixes.

@ps-19 ps-19 requested a review from lingsamuel April 6, 2023 07:27
@lingsamuel
Copy link
Member

Please sync changes from https://github.com/apache/apisix-ingress-controller/blob/master/.github/workflows/e2e-test-ci.yml#L189-L200 , there are some necessary stability fixes.

@ps-19
Copy link
Contributor Author

ps-19 commented Apr 13, 2023

I installed a red hat extension which changes the syntax. That is why this PR failed in test.

@tao12345666333
Copy link
Member

We should actually run it in GitHub Action to ensure that it meets expectations. #1721 (comment)

@ps-19
Copy link
Contributor Author

ps-19 commented Apr 17, 2023

I think the CI might have failed due to flaky errors.

@tao12345666333
Copy link
Member

I will re-run CI.

@ps-19
Copy link
Contributor Author

ps-19 commented Apr 20, 2023

Can you please run the tests again please? It will be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: add regression testing with apisix:dev
6 participants