Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cron ci must use the logical AND condition #1850

Merged
merged 5 commits into from
Jul 31, 2023
Merged

ci: cron ci must use the logical AND condition #1850

merged 5 commits into from
Jul 31, 2023

Conversation

Chever-John
Copy link
Contributor

@Chever-John Chever-John commented Jun 1, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Maybe there is an error in the ci logic.
link #1849

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Merging #1850 (f3cac3c) into master (7540872) will not change coverage.
The diff coverage is n/a.

❗ Current head f3cac3c differs from pull request most recent head 9043244. Consider uploading reports for the commit 9043244 to get more accurate results

@@           Coverage Diff           @@
##           master    #1850   +/-   ##
=======================================
  Coverage   39.82%   39.82%           
=======================================
  Files          92       92           
  Lines        7261     7261           
=======================================
  Hits         2892     2892           
  Misses       3985     3985           
  Partials      384      384           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

.github/workflows/e2e-test-ci-v2-cron-dev.yml Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member

CI errors are unrelated to modifications. We can skip it.

@tao12345666333 tao12345666333 merged commit c40b664 into apache:master Jul 31, 2023
51 of 52 checks passed
@tao12345666333 tao12345666333 linked an issue Aug 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cron CI judgment logic problem
4 participants