feat: allow configuring timeout and retries for upstream with ingress

[Revolyssup]

Type of change:

Fixes #1783

Documentation to be updated.

• Bugfix
• New feature provided
• Improve performance
• Backport patches
• Documentation
• Refactor
• Chore
• CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

• Did you explain what problem does this PR solve? Or what new features have been added?
• Have you added corresponding test cases?
• Have you modified the corresponding document?
• Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

[codecov-commenter]

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (7a9a0fa) 37.12% compared to head (aec4d5a) 37.13%.
Report is 1 commits behind head on master.

❗ Current head aec4d5a differs from pull request most recent head af956c7. Consider uploading reports for the commit af956c7 to get more accurate results

Files	Patch %	Lines
pkg/providers/ingress/translation/translator.go	0.00%	32 Missing ⚠️
...gress/translation/annotations/upstream/upstream.go	83.78%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1876   +/-   ##
=======================================
  Coverage   37.12%   37.13%           
=======================================
  Files          93       93           
  Lines        7886     7938   +52     
=======================================
+ Hits         2928     2948   +20     
- Misses       4568     4598   +30     
- Partials      390      392    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lingsamuel]

make update-gofmt (or make update-all) is required

[lingsamuel]

maybe e2e-test is needed @tao12345666333 wdyt

[tao12345666333]

yes, we need an e2e test case to cover this one.

[Revolyssup]

@tao12345666333 How do you suggest I simulate backend for testing retries and timeouts? For retries, I configured an http server on port 8080 that responds with 200 on 3rd attempt(400 previously) and the I set the retry to 3, but tests seem to fail. Do you have a better approach? Or is there some issue with my approach?

[tao12345666333]

Using the serverless plugin of APISIX, it will be easier to simulate with Lua.

[AlinsRan]

Please provide documentation for this feature.
https://apisix.apache.org/docs/ingress-controller/concepts/annotations

[AlinsRan]

What timeout? The timeout here has many layers of meaning, should it be a client or a service?
You should clarify the target or object of the timeout.

Retrying is also the same.

[Revolyssup]

How about, upstream.retries and upstream.timeout.read? @AlinsRan

[AlinsRan]

I suggest using - as the separator for annotations name, which is the format we are currently using. Please maintain consistency.

upstream-retries
upstream-read-timeout.

[kayx23]

some suggestions for docs