Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: auto certs #1911

Merged
merged 3 commits into from
Aug 2, 2023
Merged

ci: auto certs #1911

merged 3 commits into from
Aug 2, 2023

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Jul 31, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

fixes: #1182

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #1911 (ab712b5) into master (c40b664) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head ab712b5 differs from pull request most recent head f23ccb3. Consider uploading reports for the commit f23ccb3 to get more accurate results

@@           Coverage Diff           @@
##           master    #1911   +/-   ##
=======================================
  Coverage   39.87%   39.87%           
=======================================
  Files          92       92           
  Lines        7266     7266           
=======================================
  Hits         2897     2897           
  Misses       3985     3985           
  Partials      384      384           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Aug 1, 2023
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
Copy link
Member Author

https://github.com/apache/apisix-ingress-controller/actions/runs/5724070495/job/15512102594?pr=1911#step:8:3067

  	            		Error:      	
  	            		            	unexpected http status value
  	            		            	
  	            		            	request: GET /ip HTTP/1.1
  	            		            	  Host: httpbin.org
  	            		            	  X-Foo: bar
  	            		            	
  	            		            	response: HTTP/1.1 504 Gateway Time-out 10.125895416s
  	            		            	  Content-Length: 132
  	            		            	  Connection: keep-alive
  	            		            	  Content-Type: text/html; charset=utf-8
  	            		            	  Date: Tue, 01 Aug 2023 09:25:26 GMT
  	            		            	  Server: APISIX/3.4.1
  	            		            	  X-Apisix-Upstream-Status: 504
  	            		            	
  	            		            	assertion:
  	            		            	  Request("GET").Expect().Status()
  	            		            	
  	            		            	expected value:
  	            		            	  "200 OK"
  	            		            	
  	            		            	actual value:
  	            		            	  "504 Gateway Timeout"
  	Test:       	suite-features: external services complex usage:  should be able to access multiple external services
  
  In [It] at: /home/runner/go/pkg/mod/github.com/gavv/httpexpect/v2@v2.15.0/reporter.go:24 @ 08/01/23 09:25:26.315

The only failed case now is due to the instability of httpbin.org.

@tao12345666333
Copy link
Member Author

passed!!!!

@tao12345666333 tao12345666333 merged commit 3f45ca9 into apache:master Aug 2, 2023
53 checks passed
@tao12345666333 tao12345666333 deleted the auto-certs branch August 2, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

e2e: require certificate from file and add certificate generation script
4 participants