Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed field in examples according to CRD #2032

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Renamed field in examples according to CRD #2032

merged 1 commit into from
Nov 6, 2023

Conversation

nayavu
Copy link
Contributor

@nayavu nayavu commented Nov 3, 2023

Renamed enabled to enable according to CRD

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Fixed a mistake in docs.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@nayavu
Renamed field according to CRD
5f55947 
Renamed `enabled` to `enable` according to CRD
@nayavu nayavu mentioned this pull request Nov 3, 2023
Closed
Gallardot
Gallardot approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@lingsamuel lingsamuel merged commit e2870a8 into apache:master Nov 6, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallardot Gallardot Gallardot approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nayavu @Gallardot @lingsamuel