docs: add best practice docs to avoid race condition bw kubelet and apisix #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pisix Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
kayx23
reviewed
Nov 15, 2023
docs/en/latest/tutorials/how-to-avoid-race-condition-when-scaling-down.md
Outdated
Show resolved
Hide resolved
docs/en/latest/tutorials/how-to-avoid-race-condition-when-scaling-down.md
Outdated
Show resolved
Hide resolved
docs/en/latest/tutorials/how-to-avoid-race-condition-when-scaling-down.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Traky Deng <trakydeng@gmail.com>
kayx23
approved these changes
Nov 15, 2023
Sn0rt
reviewed
Nov 16, 2023
| lifecycle: | ||
| preStop: | ||
| exec: | ||
| command: ["/bin/sh", "-c", "sleep 5 && kill -SIGTERM $(cat /var/run/webserver.pid)"] |
There was a problem hiding this comment.
This user case is not concise enough and misleading. I think just writing sleep 5 is enough. It means that sleep 5 gives the apisix ingress controller enough time to process the control plane changes.
|
@Sn0rt I applied the suggestion. PTAL |
Sn0rt
approved these changes
Nov 17, 2023
AlinsRan
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
Fixes #2030
What this PR does / why we need it:
Pre-submission checklist: