refactoring helm chart

[junnplus]

• Related issues
  closes request help: separated base chart or merge base chart #209

---

New feature or improvement

merge base and ingress-apisix helm chart

[codecov-io]

Codecov Report

Merging #213 (245f897) into master (549d67d) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   44.52%   44.55%   +0.02%     
==========================================
  Files          32       33       +1     
  Lines        2019     2020       +1     
==========================================
+ Hits          899      900       +1     
  Misses        981      981              
  Partials      139      139              

Impacted Files	Coverage Δ
test/e2e/e2e.go	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549d67d...245f897. Read the comment docs.

[tokers]

@junnplus The installation of CRDs (and the ClusterRole) should be optional, if we have multiple Ingress controller Deployments, only the first installation should apply them, you can refer to https://github.com/Kong/charts/blob/main/charts/kong/values.yaml#L346 as a reference.

[junnplus]

@tokers installCRDs of kong is for compatibility helm2. this chart require helm 3.0+.

see more in chart best practices

With the arrival of Helm 3, we removed the old crd-install hooks for a more simple methodology. There is now a special directory called crds that you can create in your chart to hold your CRDs. These CRDs are not templated, but will be installed by default when running a helm install for the chart. If the CRD already exists, it will be skipped with a warning. If you wish to skip the CRD installation step, you can pass the --skip-crds flag.

if need to be compatible helm2, I can make additional pr for it.

[tokers]

@tokers installCRDs of kong is for compatibility helm2. this chart require helm 3.0+.

see more in chart best practices

With the arrival of Helm 3, we removed the old crd-install hooks for a more simple methodology. There is now a special directory called crds that you can create in your chart to hold your CRDs. These CRDs are not templated, but will be installed by default when running a helm install for the chart. If the CRD already exists, it will be skipped with a warning. If you wish to skip the CRD installation step, you can pass the --skip-crds flag.

if need to be compatible helm2, I can make additional pr for it.

Sorry, i'm not so familiar with Helm, just want to know how to skip installing CRDs in helm 3.0+.

[junnplus]

@tokers Any other questions?

[tokers]

@junnplus LGTM, will need other reviewers to dome double check. Thank you again!

[membphis]

LGTM, @starsz do you have time to look at this PR?

[gxthrj]

Sorry for the late reply, glad to see your discussion.

[junnplus]

@gxthrj Can we merge this PR? cc @tokers

[tokers]

@junnplus Yes it can be, the broken e2e case is not related with the changes in this PR. It should be fixed in another PR.

@gxthrj

[tokers]

@junnplus Please update your branch with the newest master, it fixed the broken e2e case, after that, your PR can be merged :)

[junnplus]

ping @tokers