Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ApisixRoute v2alpha1 #262

Merged
merged 21 commits into from
Mar 3, 2021
Merged

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Feb 23, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues

#248


New feature or improvement

  • Describe the details and related test reports.
    This PR implemented the ApisixRoute.apisix.apache.org/v2/alpha1 resource. Generate the required listers, informers for it.

@tokers
Copy link
Contributor Author

tokers commented Feb 23, 2021

@gxthrj Please take a look when you have time.

@gxthrj
Copy link
Contributor

gxthrj commented Feb 25, 2021

Conflicting files

@@ -338,17 +340,6 @@ type Api6Controller struct {
Stop <-chan struct{}
}

func (api6 *Api6Controller) ApisixRoute(controller *Controller) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed earlier that we should keep the v1 version for a while, declare in the document "deprecated", and delete the logic of v1 in version 1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to set this PR to draft, the v1 ApisixRoute will be kept of course.

@tokers tokers marked this pull request as draft February 25, 2021 05:15
@tokers tokers marked this pull request as ready for review March 1, 2021 08:08
@codecov-io
Copy link

codecov-io commented Mar 1, 2021

Codecov Report

Merging #262 (de03db9) into master (0c8f306) will decrease coverage by 1.58%.
The diff coverage is 9.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   53.85%   52.26%   -1.59%     
==========================================
  Files          33       32       -1     
  Lines        2245     2319      +74     
==========================================
+ Hits         1209     1212       +3     
- Misses        879      950      +71     
  Partials      157      157              
Impacted Files Coverage Δ
pkg/kube/translation/apisix_route.go 0.00% <0.00%> (ø)
pkg/kube/translation/translator.go 53.03% <ø> (ø)
cmd/ingress/ingress.go 74.32% <100.00%> (+0.35%) ⬆️
pkg/config/config.go 80.48% <100.00%> (+0.48%) ⬆️
test/e2e/e2e.go
pkg/seven/state/solver.go 4.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8f306...de03db9. Read the comment docs.

- /ip
backend:
serviceName: %s
servicePort: %d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more test case with v2alpha1. We may add more in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@tokers tokers linked an issue Mar 3, 2021 that may be closed by this pull request
@tokers tokers merged commit c65cc23 into apache:master Mar 3, 2021
@tokers tokers deleted the feat/apisixroute-v2alpha1 branch March 3, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discuss: ApisixRoute change struct
3 participants