Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use networking informer instead of extensions #296

Merged
merged 1 commit into from Mar 15, 2021

Conversation

junnplus
Copy link
Contributor

@junnplus junnplus commented Mar 12, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • Related issues


Bugfix

@codecov-io
Copy link

Codecov Report

Merging #296 (4a3657d) into master (038a047) will increase coverage by 47.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           master      #296       +/-   ##
============================================
+ Coverage   52.21%   100.00%   +47.78%     
============================================
  Files          33         1       -32     
  Lines        2321         1     -2320     
============================================
- Hits         1212         1     -1211     
+ Misses        952         0      -952     
+ Partials      157         0      -157     
Impacted Files Coverage Δ
pkg/api/router/router.go
pkg/version/version.go
pkg/seven/state/route_worker.go
pkg/log/options.go
pkg/seven/state/builder.go
pkg/ingress/apisix/tls.go
pkg/apisix/route.go
pkg/apisix/ssl.go
pkg/apisix/cache/memdb.go
pkg/kube/translation/annotations.go
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038a047...4a3657d. Read the comment docs.

@membphis
Copy link
Member

membphis commented Mar 14, 2021

ping @gxthrj

@gxthrj gxthrj merged commit 51ef09c into apache:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: crash when exist v1beta1.Ingress of extensions
5 participants