Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support nginx vars in ApisixRoute v2alpha1 #304

Merged
merged 4 commits into from
Mar 17, 2021
Merged

feat: support nginx vars in ApisixRoute v2alpha1 #304

merged 4 commits into from
Mar 17, 2021

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Mar 16, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues

#302

  • Features

This Pull Request aims at exposing the nginxVars field in ApisixRoute/v2alpha1, the apisix-ingress-controller will translate the nginxVars to vars in Route.

@tokers tokers requested a review from gxthrj March 16, 2021 09:33
@tokers tokers self-assigned this Mar 16, 2021
@tokers tokers added enhancement New feature or request feature labels Mar 16, 2021
@tokers tokers added this to the 0.5.0 milestone Mar 16, 2021
@tokers tokers linked an issue Mar 16, 2021 that may be closed by this pull request
request help: ApisixRoute support ngx_vars logic #302
Closed
@tokers tokers marked this pull request as draft March 16, 2021 09:34
@tokers tokers marked this pull request as ready for review March 17, 2021 03:32
@gxthrj
Copy link
Contributor

gxthrj commented Mar 17, 2021

Need docs for the usage of nginxVars.

@tokers
Copy link
Contributor Author

tokers commented Mar 17, 2021

@gxthrj Please take a look when you have time.

@gxthrj gxthrj merged commit f45203e into apache:master Mar 17, 2021
@oldthreefeng
Copy link

这个对应的是 route里面的 这个vars变量吧. 我没理解错吧.

  "vars": [
    [
      "scheme",    => subject
      "==",           => op
      "http"          => value
    ]
  ],

@gxthrj
Copy link
Contributor

gxthrj commented Mar 18, 2021

这个对应的是 route里面的 这个vars变量吧. 我没理解错吧.

  "vars": [
    [
      "scheme",    => subject
      "==",           => op
      "http"          => value
    ]
  ],

Right！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gxthrj gxthrj gxthrj approved these changes

Assignees

@tokers tokers

Labels
enhancement New feature or request feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

request help: ApisixRoute support ngx_vars logic
3 participants
@tokers @gxthrj @oldthreefeng