fix: ApisixRoute update operations is not effective #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gxthrj Please take a look when you have time. |
gxthrj
reviewed
Mar 29, 2021
| name: httpbin-route | ||
| spec: | ||
| http: | ||
| - name: rule1 |
There was a problem hiding this comment.
should add cases :
the diff name in the same ApisixRoute.
the same name in the diff ApisixRoute.
There was a problem hiding this comment.
Cannot totally capture your mean.
There was a problem hiding this comment.
I mean add test cases:
- In the same
ApisixRouteyaml ,but changespec.http.namewhen update - In the different
ApisixRouteyaml, but have the samespec.http.name, which means name is conflict.
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 39.25% 41.84% +2.59%
==========================================
Files 42 39 -3
Lines 3577 3444 -133
==========================================
+ Hits 1404 1441 +37
+ Misses 2012 1842 -170
Partials 161 161
Continue to review full report at Codecov.
|
gxthrj
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
bug: Modify the route.yaml configuration to not update apisix synchronously #312
What does this PR do:
manifest, it's used byApisixRouteController,IngressControllerandEndpointController.pkg/seven/state.Create and remove the ApisixRoute, adding update operation and sending requests to APISIX.