test: add e2e test cases for redirect, uri-blocker and fault-injection plugins #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
============================================
+ Coverage 39.25% 100.00% +60.74%
============================================
Files 42 1 -41
Lines 3577 1 -3576
============================================
- Hits 1404 1 -1403
+ Misses 2012 0 -2012
+ Partials 161 0 -161 Continue to review full report at Codecov.
|
tokers
changed the title
gxthrj
reviewed
Mar 31, 2021
| @@ -174,7 +174,7 @@ type ApisixRouteHTTPPlugin struct { | |||
| Enable bool `json:"enable" yaml:"enable"` | |||
| // Plugin configuration. | |||
| // TODO we may use protobuf to define it. | |||
| Config ApisixRouteHTTPPluginConfig | |||
| Config ApisixRouteHTTPPluginConfig `json:"config" yaml:"enable"` | |||
There was a problem hiding this comment.
Suggested change
| Config ApisixRouteHTTPPluginConfig `json:"config" yaml:"enable"` | |
| Config ApisixRouteHTTPPluginConfig `json:"config" yaml:"config"` |
gxthrj
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch