Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add name field when create route and upstream #333

Merged
merged 3 commits into from Apr 2, 2021
Merged

fix: add name field when create route and upstream #333

merged 3 commits into from Apr 2, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Apr 2, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

  • Description

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.
    add name field when create route and upstream, in order to fit apisix-dashboard.
    the name field is a required field in the apisix-dashboard's route and upstream.

Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@codecov-io
Copy link

codecov-io commented Apr 2, 2021

Codecov Report

Merging #333 (44641ed) into master (8006297) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   43.72%   43.36%   -0.37%     
==========================================
  Files          40       39       -1     
  Lines        3428     3434       +6     
==========================================
- Hits         1499     1489      -10     
- Misses       1761     1775      +14     
- Partials      168      170       +2     
Impacted Files Coverage Δ
pkg/apisix/resource.go 78.43% <100.00%> (+0.21%) ⬆️
pkg/apisix/route.go 43.47% <100.00%> (-0.48%) ⬇️
pkg/apisix/upstream.go 46.85% <100.00%> (+0.61%) ⬆️
pkg/apisix/cluster.go 28.44% <0.00%> (-5.97%) ⬇️
test/e2e/e2e.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8006297...44641ed. Read the comment docs.

@tokers
Copy link
Contributor

tokers commented Apr 2, 2021

@okaybase Thanks for your contribution. I added some test cases for your changes, you may look through it.

@okaybase
Copy link
Member Author

okaybase commented Apr 2, 2021

@tokers thanks very much for your test cases and help! 😄

@tokers tokers merged commit 2cc9c76 into apache:master Apr 2, 2021
@okaybase okaybase deleted the okaybase branch April 14, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants