test: add e2e test cases for proxy-rewrite plugin #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 43.84% 43.82% -0.02%
==========================================
Files 40 39 -1
Lines 3435 3434 -1
==========================================
- Hits 1506 1505 -1
Misses 1761 1761
Partials 168 168
Continue to review full report at Codecov.
|
tokers
reviewed
Apr 7, 2021
test/e2e/plugins/proxy_rewrite.go
Outdated
|
|
||
| s.NewAPISIXClient().GET("/hello").WithHeader("Host", "httpbin.org"). | ||
| Expect(). | ||
| Status(200) |
There was a problem hiding this comment.
Also check the body, which contains the string "origin".
|
Missing cases for regex_uri and headers. |
|
Ping @Firstsawyou Any updates? |
Being resolved. |
|
@Firstsawyou Please fix the e2e failure problem. |
Fixed. |
tokers
reviewed
Apr 8, 2021
tokers
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
close #335
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch