Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add apisixconsumer data structures #462

Merged
merged 3 commits into from May 24, 2021

Conversation

tokers
Copy link
Contributor

@tokers tokers commented May 18, 2021

Please answer these questions before submitting a pull request

This Pull Request adds the basic CRD and go struct data structures.

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

  • Description

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@tokers tokers marked this pull request as draft May 18, 2021 06:08
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #462 (cb98a20) into master (015940c) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head cb98a20 differs from pull request most recent head 1ccd4f6. Consider uploading reports for the commit 1ccd4f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   37.04%   36.99%   -0.06%     
==========================================
  Files          47       46       -1     
  Lines        3841     3844       +3     
==========================================
- Hits         1423     1422       -1     
- Misses       2233     2237       +4     
  Partials      185      185              
Impacted Files Coverage Δ
pkg/apisix/cluster.go 26.69% <0.00%> (-0.35%) ⬇️
pkg/ingress/controller.go 0.00% <0.00%> (ø)
pkg/ingress/endpoint.go 0.00% <0.00%> (ø)
test/e2e/e2e.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015940c...1ccd4f6. Read the comment docs.

@tokers tokers marked this pull request as ready for review May 19, 2021 04:30
@tokers
Copy link
Contributor Author

tokers commented May 20, 2021

@gxthrj Please look it again.

@tokers tokers mentioned this pull request May 20, 2021
4 tasks
@tokers tokers merged commit bc71e3e into apache:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants