Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for http-to-https redirect annotation #484

Merged
merged 3 commits into from May 26, 2021

Conversation

tao12345666333
Copy link
Member

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


New feature or improvement

You can use the following annotations to control the redirect behavior.

  • k8s.apisix.apache.org/http-to-https

If this annotation set to true and the request is HTTP, it will be automatically redirected to HTTPS with 301 response code, and the URI will keep the same as client request.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #484 (73d9371) into master (6630aac) will increase coverage by 0.15%.
The diff coverage is 0.00%.

❗ Current head 73d9371 differs from pull request most recent head 7a754d6. Consider uploading reports for the commit 7a754d6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   36.84%   37.00%   +0.15%     
==========================================
  Files          49       50       +1     
  Lines        4030     4035       +5     
==========================================
+ Hits         1485     1493       +8     
- Misses       2342     2343       +1     
+ Partials      203      199       -4     
Impacted Files Coverage Δ
pkg/kube/translation/annotations.go 54.54% <ø> (+18.18%) ⬆️
pkg/kube/translation/annotations/redirect.go 0.00% <0.00%> (ø)
pkg/kube/translation/ingress.go 91.33% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6630aac...7a754d6. Read the comment docs.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@spacewander spacewander merged commit 77a06cc into apache:master May 26, 2021
@tao12345666333 tao12345666333 deleted the feat-proxy-redirect-anno branch May 26, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants