Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add authentication for ApisixRoute #528

Merged
merged 6 commits into from Jun 9, 2021

Conversation

tao12345666333
Copy link
Member

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

  • Description

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

@tao12345666333 tao12345666333 changed the title Feat ar add auth chore: add authentication for ApisixRoute Jun 4, 2021
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 marked this pull request as ready for review June 8, 2021 06:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #528 (ddeccc4) into master (f6cb4f9) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   34.82%   34.76%   -0.07%     
==========================================
  Files          54       55       +1     
  Lines        4497     4508      +11     
==========================================
+ Hits         1566     1567       +1     
- Misses       2716     2725       +9     
- Partials      215      216       +1     
Impacted Files Coverage Δ
pkg/ingress/controller.go 1.12% <0.00%> (-0.01%) ⬇️
pkg/kube/translation/apisix_route.go 41.12% <0.00%> (-1.60%) ⬇️
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c584e...ddeccc4. Read the comment docs.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@gxthrj gxthrj merged commit fca6211 into apache:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants