Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not need to record status when ApisixUpstream removed #589

Merged
merged 1 commit into from Jul 14, 2021

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Jul 13, 2021

Please answer these questions before submitting a pull request


@codecov-commenter
Copy link

Codecov Report

Merging #589 (c66334a) into master (015940c) will decrease coverage by 2.64%.
The diff coverage is 19.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   37.04%   34.40%   -2.65%     
==========================================
  Files          47       55       +8     
  Lines        3841     5468    +1627     
==========================================
+ Hits         1423     1881     +458     
- Misses       2233     3362    +1129     
- Partials      185      225      +40     
Impacted Files Coverage Δ
pkg/ingress/apisix_cluster_config.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_tls.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 1.07% <0.00%> (+1.07%) ⬆️
pkg/ingress/endpoint.go 0.00% <0.00%> (ø)
pkg/ingress/endpointslice.go 0.00% <0.00%> (ø)
pkg/ingress/secret.go 0.00% <0.00%> (ø)
pkg/ingress/status.go 0.00% <0.00%> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ec6da...c66334a. Read the comment docs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gxthrj gxthrj merged commit 7291212 into apache:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Should not call func recordStatus when only delete ApisixUpstream
4 participants