feat: support ingress v1beta1 https #596
Conversation
pkg/ingress/manifest.go
Outdated
| } | ||
|
|
||
| func (m *manifest) diff(om *manifest) (added, updated, deleted *manifest) { | ||
| // TODO add diff ssl |
pkg/kube/translation/ingress.go
Outdated
| @@ -93,7 +96,37 @@ func (t *translator) translateIngressV1beta1(ing *networkingv1beta1.Ingress) (*T | |||
| upstreamMap: make(map[string]struct{}), | |||
| } | |||
| plugins := t.translateAnnotations(ing.Annotations) | |||
|
|
|||
| // TODO add https | |||
|
BTW, we need to add some e2e test cases for TLS, |
tao12345666333
added
changelog
pkg/ingress/ingress.go
Outdated
| @@ -168,6 +170,7 @@ func (c *ingressController) sync(ctx context.Context, ev *types.Event) error { | |||
| om := &manifest{ | |||
| routes: oldCtx.Routes, | |||
| upstreams: oldCtx.Upstreams, | |||
| ssl: oldCtx.SSL, | |||
|
@tianshimoyi Please check out the CI problems. |
|
@tianshimoyi Please format the code, then add UT and e2e test. |
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
==========================================
- Coverage 34.40% 34.14% -0.26%
==========================================
Files 55 55
Lines 5468 5530 +62
==========================================
+ Hits 1881 1888 +7
- Misses 3362 3416 +54
- Partials 225 226 +1
Continue to review full report at Codecov.
|
|
Look good to me. |
The reason is that I didn't download the dependency under test / exe, which has been solved. |
|
[Fail] ApisixRoute Testing [It] create, update, remove k8s service, remove ApisixRoute What is the cause of this error? I did not modify this place. |
Just re-run it. |
Looks more wrong
|
|
re-run e2e jobs. |
|
This error has appeared many times, this error is not my error, please correct it. |
|
thanks for your contributions, I will check it |
pkg/kube/translation/ingress.go
Outdated
| @@ -15,19 +15,20 @@ | |||
| package translation | |||
|
|
|||
| import ( | |||
| "go.uber.org/zap" | |||
There was a problem hiding this comment.
Please classify the import packages.
This is a 3rd party packages, and it should be put with other 3rd party packages.
tao12345666333
changed the title
Please answer these questions before submitting a pull request
Why submit this pull request?
New feature provided
Related issues
feat: add TLS support for Ingress resources #586
New feature or improvement