Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e failure due to count returned by APISIX #640

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

lingsamuel
Copy link
Member

@lingsamuel lingsamuel commented Aug 19, 2021

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

  • Bugfix

Bugfix

  • Description
    image

If the count field is string, its value is greater than actual value by 1.

  • How to fix?

Decrease count if its type is string.

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #640 (1c53349) into master (91d985e) will increase coverage by 0.33%.
The diff coverage is n/a.

❗ Current head 1c53349 differs from pull request most recent head ba56dc4. Consider uploading reports for the commit ba56dc4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   34.46%   34.79%   +0.33%     
==========================================
  Files          57       57              
  Lines        5722     5722              
==========================================
+ Hits         1972     1991      +19     
+ Misses       3504     3492      -12     
+ Partials      246      239       -7     
Impacted Files Coverage Δ
pkg/apisix/route.go 37.76% <0.00%> (+2.09%) ⬆️
pkg/apisix/cluster.go 30.47% <0.00%> (+3.27%) ⬆️
pkg/apisix/plugin.go 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8854c3...ba56dc4. Read the comment docs.

@gxthrj gxthrj merged commit 270a176 into apache:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants