chore: introduce a CLI interface and a Makefile. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI interface is not in use now.
gxthrj
reviewed
Dec 8, 2020
| // cmd.PersistentFlags().StringVar(&conf.SyslogServer, "syslog-server", "", "syslog server address") | ||
|
|
||
| return cmd | ||
| } |
membphis
requested changes
Dec 8, 2020
| @@ -7,5 +7,5 @@ sed -i -e "s%#syslogAddress#%`echo $SYSLOG_HOST`%g" ${pwd}/conf.json | |||
| sed -i -e "s%#apisixBaseUrl#%`echo $APISIX_BASE_URL`%g" ${pwd}/conf.json | |||
|
|
|||
| cd /root/ingress-controller | |||
| exec ./ingress-controller | |||
| exec ./ingress-controller ingress | |||
There was a problem hiding this comment.
why we need the argument ingress?
There was a problem hiding this comment.
We put all core logic about "ingress controller" in the sub command ingress, and we can extend this tool by adding others sub command, for instance, some debugging tools to fetch its internal states, or adding the service apis support by the "gateway" sub command. So using sub commands is more flexible.
It's not easy to add test cases now, since the config is so tricky, then program cannot run unless we modify the configuration file manually. I will add test cases after we refactoring the configuration module. |
|
I have created an issue #70 to track the test cases. |
gxthrj
approved these changes
Dec 9, 2020
membphis
reviewed
Dec 9, 2020
membphis
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI interface is not in use now.