Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add full compare when ingress startup #680

Merged
merged 15 commits into from Sep 24, 2021
Merged

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Sep 13, 2021

Please answer these questions before submitting a pull request

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #680 (0a7eced) into master (5c9cdbe) will decrease coverage by 0.84%.
The diff coverage is 2.61%.

❗ Current head 0a7eced differs from pull request most recent head 77e66bf. Consider uploading reports for the commit 77e66bf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
- Coverage   35.04%   34.19%   -0.85%     
==========================================
  Files          60       61       +1     
  Lines        5967     6117     +150     
==========================================
+ Hits         2091     2092       +1     
- Misses       3625     3774     +149     
  Partials      251      251              
Impacted Files Coverage Δ
pkg/apisix/schema.go 63.26% <ø> (ø)
pkg/ingress/compare.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 1.06% <0.00%> (-0.01%) ⬇️
pkg/ingress/pod.go 32.46% <100.00%> (+0.88%) ⬆️
pkg/kube/translation/apisix_upstream.go 88.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9cdbe...77e66bf. Read the comment docs.

@gxthrj gxthrj changed the title WIP: add full compare when ingress startup feat: add full compare when ingress startup Sep 15, 2021
utils/kind-with-registry.sh Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
@tokers
Copy link
Contributor

tokers commented Sep 17, 2021

@gxthrj There are a couple of lint errors, please fix them.

pkg/ingress/compare.go Outdated Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants