Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore delete pod cache error msg #714

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

Donghui0
Copy link
Contributor

@Donghui0 Donghui0 commented Oct 15, 2021

Please answer these questions before submitting a pull request


Bugfix

  • Description

  • How to fix?
    modify the return value ErrPodNoAssignedIP -> nil.

@codecov-commenter
Copy link

Codecov Report

Merging #714 (11f7c00) into master (a01888b) will increase coverage by 67.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           master      #714       +/-   ##
============================================
+ Coverage   32.36%   100.00%   +67.63%     
============================================
  Files          65         1       -64     
  Lines        6488         1     -6487     
============================================
- Hits         2100         1     -2099     
+ Misses       4137         0     -4137     
+ Partials      251         0      -251     
Impacted Files Coverage Δ
pkg/types/pod.go
pkg/metrics/prometheus.go
pkg/api/server.go
pkg/apisix/plugin.go
pkg/kube/translation/apisix_ssl.go
pkg/apisix/apisix.go
pkg/ingress/controller.go
pkg/apisix/route.go
pkg/kube/translation/annotations/iprestriction.go
pkg/apisix/consumer.go
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a290f12...11f7c00. Read the comment docs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please fix the unit test case.

--- FAIL: TestPodCacheBadCases (0.00s)
    pod_test.go:39: 
        	Error Trace:	pod_test.go:39
        	Error:      	Not equal: 
        	            	expected: <nil>(<nil>)
        	            	actual  : *errors.errorString(&errors.errorString{s:"pod not running"})
        	Test:       	TestPodCacheBadCases
        	Messages:   	deleting pod
FAIL
coverage: 87.0% of statements
FAIL	github.com/apache/apisix-ingress-controller/pkg/types	0.005s
?   	github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1	[no test files]
ok  	github.com/apache/apisix-ingress-controller/pkg/version	0.003s	coverage: 100.0% of statements
FAIL

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM

@tao12345666333 tao12345666333 merged commit 97fdc90 into apache:master Oct 20, 2021
@tao12345666333 tao12345666333 linked an issue Oct 20, 2021 that may be closed by this pull request
@tao12345666333 tao12345666333 added this to the 1.4.0 milestone Oct 20, 2021
@tao12345666333 tao12345666333 added this to In progress in v1.4 Planning via automation Oct 20, 2021
@tao12345666333 tao12345666333 moved this from In progress to Done in v1.4 Planning Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

request help: error log "failed to delete pod from cache"
4 participants